fix: replace archived image-size dependency for upload dimensions#17077
Open
r1tsuu wants to merge 3 commits into
Open
fix: replace archived image-size dependency for upload dimensions#17077r1tsuu wants to merge 3 commits into
r1tsuu wants to merge 3 commits into
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
AlessioGr
requested changes
Jun 22, 2026
| * with its own `ispe`; the largest is the primary image, matching what the | ||
| * previous `image-size` implementation reported. | ||
| */ | ||
| function readHEIF(data: Buffer): Dimensions { |
Member
There was a problem hiding this comment.
Hm, I really don't think we should maintain this. Is there an alternative package we can use?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the direct runtime dependency on the archived
image-sizepackage.Upload dimensions now come from
sharpwhen it's configured, with a smallzero-dependency probe as the fallback for sharp-less installs.
Why
image-sizeis archived and stuck at2.0.2with unpatched DoS advisories(CVE-2025-71330, CVE-2025-71319) reachable via crafted uploads. No upstream fix
is coming.
sharpstays optional.How
getImageSizepreferssharp.metadata()whensharpis configured.probeImageSizereads header bytes for PNG, JPEG, GIF, BMP, WebP, TIFF,SVG, AVIF/HEIF and ICO, with bounded scans (the CVE trigger can't loop).
image-sizefrompackage.json/ the lockfile.Testing
Unit specs cover both the sharp and probe paths. Output verified identical to
the old
image-sizeacross 61 real images (cross-checked withsharpandsips), including HEIC files that embed a thumbnail before the primary image.