[Bug] CardFields type for onApprove callback incorrect

[jonty-comp]

Library used

paypal-js

🐞 Describe the Bug

The documentation at https://developer.paypal.com/docs/checkout/advanced/customize/3d-secure/sdk/ shows an implementation that handles 3D-Secure liability shift in the onApprove callback, before calling to capture the transaction. This includes a liabilityShift property in the data passed to the callback.

The types definition for CardFields in this library has a CardFieldsOnApproveData type, but it doesn't include this liabilityShift property, so I have to extend manually.

🤔 Expected Behavior

paypal-js/packages/paypal-js/types/components/card-fields.d.ts

Lines 39 to 41 in a2e716e

	export type CardFieldsOnApproveData = {
	orderID: string;
	};

should contain a liabilityShift property with the appropriate sub-properties - presumably as per https://developer.paypal.com/docs/checkout/advanced/customize/3d-secure/response-parameters/

[maishivamhoo123]

@team can I work on this issue?

[prameshbajra]

Please note that for Vault mode, CardFieldsOnApproveData should also have vaultSetupToken instead of just orderId.