Skip to content

Suggestion - remove value from default_string_format_check exception #353

@VictorJimenez99

Description

@VictorJimenez99

Hi,
About the default_string_format_check function here

value is already proccessed by the error handler interface in the instance parameter shown below

class JSON_SCHEMA_VALIDATOR_API error_handler
{
public:
	virtual ~error_handler() {}
	virtual void error(const json::json_pointer & /*ptr*/, const json & /*instance*/, const std::string & /*message*/) = 0;
};

could it be possible to remove value from the exception string?

regex format doesn't show this behaviour but email and every other format do.
And since email could be considered "personally identifiable information" theres a risk of mishandleing the information. Due to it being different from other error instances.

And while anyone can create their own format_validator to avoid this issue, it would be the exact same thing without value in the exception.

Theres no actual error in the implementation as far as I'm aware, so thats why it's just a suggestion.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions