🙏 Support for CREATE3

[sebastiantf]

Why no CREATE3 support yet? Is it planned?

[pcaversaccio]

Well, xdeployer intentionally focuses only on CREATE2-based deployments (i.e. contract creation bytecode equivalence) and I do not plan to add CREATE3-based deployments for now (the same for CREATE-based deployments). That being said, it is very easy to enable support for CREATE3 locally for you; replace in the following lines:

xdeployer/src/index.ts

Lines 163 to 167 in d33ed8a

	createReceipt[i] = await create2Deployer[i].deployCreate2(
	hre.ethers.id(hre.config.xdeploy.salt),
	initcode.data,
	{ gasLimit: hre.config.xdeploy.gasLimit },
	);

xdeployer/src/index.ts

Lines 296 to 300 in d33ed8a

	createReceipt[i] = await create2Deployer[i].deployCreate2(
	hre.ethers.id(hre.config.xdeploy.salt),
	initcode.data,
	{ gasLimit: hre.config.xdeploy.gasLimit },
	);

with (simply replace deployCreate2 with deployCreate3):

createReceipt[i] = await create2Deployer[i].deployCreate3(
  hre.ethers.id(hre.config.xdeploy.salt),
  initcode.data,
  { gasLimit: hre.config.xdeploy.gasLimit },
);

and make sure the computed addresses are correct as well; thus replace in the following lines:

xdeployer/src/index.ts

Lines 129 to 134 in d33ed8a

	computedContractAddress = await create2Deployer[
	i
	].computeCreate2Address(
	hre.ethers.keccak256(hre.ethers.id(hre.config.xdeploy.salt)),
	hre.ethers.keccak256(initcode.data),
	);

xdeployer/src/index.ts

Lines 273 to 278 in d33ed8a

	computedContractAddress = await create2Deployer[
	i
	].computeCreate2Address(
	hre.ethers.keccak256(hre.ethers.id(hre.config.xdeploy.salt)),
	hre.ethers.keccak256(initcode.data),
	);

with (simply replace computeCreate2Address with computeCreate3Address):

computedContractAddress = await create2Deployer[
  i
].computeCreate3Address(
  hre.ethers.keccak256(hre.ethers.id(hre.config.xdeploy.salt)),
  hre.ethers.keccak256(initcode.data),
);

[sebastiantf]

Got it. Might also have to support guarded salt deploy & cross-chain protection tho. Would be nice to have these out of the box.

Thanks for the response. Was just wondering why no support.

[pcaversaccio]

Another reason why I haven't planned it (yet), is to keep xdeployer fork-friendly. The standard CREATE2 contract factory doesn't offer any CREATE or CREATE3 functions. In the current state, anyone can fork xdeployer and replace the contract factory address with a custom factory and you're good to go (as long as the function signature deployCreate2(bytes32,bytes) is the same).

[sebastiantf]

Got it. Makes sense.