Skip to content

Conversation

@frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fix #3653

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (bd8c5d3) to head (f13aa79).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3655   +/-   ##
=======================================
  Coverage   86.07%   86.07%           
=======================================
  Files         119      119           
  Lines       12353    12353           
  Branches     2052     2052           
=======================================
  Hits        10633    10633           
  Misses       1140     1140           
  Partials      580      580           
Flag Coverage Δ
unittests 85.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frostming frostming merged commit 16a27dd into main Oct 23, 2025
23 of 24 checks passed
@frostming frostming deleted the frostming/issue3653 branch October 23, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyring not used when un-substituted env var is in source credentials url, no pleasant way to override source config

2 participants