Add border to neovim floating window. #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Please provide screenshot for such big improvment, also where should be way to configure borders |
Author
|
Here's a screenshot: And I made it configurable: " top left corner, top right corner, bottom left corner, bottom right corner, top/bottom, left/right
let g:any_jump_neovim_border = ['╭', '╮','╰', '╯', '─', '│'] |
kristijanhusak
force-pushed
the
feature/neovim-border
branch
from
752d76b to
471094d
Compare
|
Hi @pechorin, Awesome project! Have you considered merging this feature in the near future? 🙏🏼 |
|
ping @pechorin |
Owner
|
I think this possible if this will be option (and not enabled by default). You can rework this, or wait for me :) |
pechorin
reviewed
Jul 12, 2021
|
|
||
| " Borders for neovim floating window, list of strings in this order | ||
| " top left corner, top right corner, bottom left corner, bottom right corner, top/bottom, left/right | ||
| let g:any_jump_neovim_border = ['╭', '╮','╰', '╯', '─', '│'] |
Owner
There was a problem hiding this comment.
Please add option, for enabling or disabling this (this should not be enabled by default)
pechorin
reviewed
Jul 12, 2021
| \ 'style': 'minimal', | ||
| \ } | ||
|
|
||
| let [topleft_b, topright_b, botleft_b, botright_b, horizontal_b, vertical_b] = g:any_jump_neovim_border |
Owner
There was a problem hiding this comment.
Please move all this logic code part to separate function :)
Author
|
This is not applicable any more because neovim has built in borders now. It should be much simpler to add it. I'll let someone else take care of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for borders for neovim floating window. Also fixes part of #27.