Skip to content

Reimplement offset() and add range()#145

Merged
hildjj merged 1 commit intopeggyjs:mainfrom
Mingun:range-offset
May 27, 2021
Merged

Reimplement offset() and add range()#145
hildjj merged 1 commit intopeggyjs:mainfrom
Mingun:range-offset

Conversation

@Mingun
Copy link
Copy Markdown
Member

@Mingun Mingun commented May 3, 2021

Backported pegjs/pegjs#528

Copy link
Copy Markdown
Contributor

@hildjj hildjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly about any of these comments; this is just for discussion.

@hildjj
Copy link
Copy Markdown
Contributor

hildjj commented May 22, 2021

Will merge after rebase and update documentation.html. See #152

@hildjj hildjj added this to the 1.2 milestone May 22, 2021
@Mingun
Copy link
Copy Markdown
Member Author

Mingun commented May 23, 2021

Updated documentation and range() definition. Ready to merge.

@Mingun Mingun requested a review from hildjj May 27, 2021 15:44
@hildjj hildjj merged commit a0e26b4 into peggyjs:main May 27, 2021
@Mingun Mingun deleted the range-offset branch May 27, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants