Fix a regression in the description of character classes in error message#197
Merged
hildjj merged 1 commit intopeggyjs:1.3from Oct 18, 2021
Merged
Fix a regression in the description of character classes in error message#197hildjj merged 1 commit intopeggyjs:1.3from
hildjj merged 1 commit intopeggyjs:1.3from
Conversation
Mingun
force-pushed
the
fix-message-regression
branch
from
898dfe4 to
00790e1
Compare
Character class description contains redundant commas between class parts: [1,2,3-5] instead of [123-5] for class [123-5]
Mingun
force-pushed
the
fix-message-regression
branch
from
00790e1 to
bd3798d
Compare
hildjj
approved these changes
Oct 18, 2021
Contributor
hildjj
left a comment
hildjj
left a comment
There was a problem hiding this comment.
Move base branch to 1.3, and I'll merge.
(I had to look up how to do this, so in case it's useful: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request)
Member
Author
|
Done |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression was introduced in the fad4ab7
Character class description contains redundant commas between class parts:
[1,2,3-5]instead of[123-5]for class[123-5]