Merged
Conversation
Member
Mingun
commented
Jun 12, 2022
Mingun
commented
Contributor
|
I like this. We should also update everything else in docs/vendor/codemirror in this PR. |
Contributor
See #48 for discussion. |
Member
Author
|
Do you mean updating to CodeMirror 6? I probably cannot do that, because my web kung-fu is very limited and the editor was significantly rewritten. |
Contributor
|
I did, but then I looked at it, and they sure managed to make Codemirror harder to get started with. Let's make sure we've got the latest build of CodeMirror5, then open a new ticket for moving to CodeMirror6, with the "Help Requested" tag. Maybe someone will pitch in. |
Contributor
|
Of course, updating to CodeMirror 5.65.5 didn't "just work" either. Let's take this as-is. I'll open the CM6 bug as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.