Fix an error in the code generator for "repeated" node#365
Merged
hildjj merged 1 commit intopeggyjs:mainfrom Mar 2, 2023
Merged
Fix an error in the code generator for "repeated" node#365hildjj merged 1 commit intopeggyjs:mainfrom
hildjj merged 1 commit intopeggyjs:mainfrom
Conversation
The 1st and the others expressions should have different offsets to the variable stack. The 2nd and more should skip the delimiter in stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem only with repeated expressions with delimiter. We cannot use the same bytecode for the 1st and the others repetitions, because after the first element the saved position is present in the variables stack. The stack in the append loop looks like:
Fixes #364.