Skip to content

Add developer docs. #469

Merged
hildjj merged 2 commits intopeggyjs:mainfrom
hildjj:fix-466
Feb 12, 2024
Merged

Add developer docs. #469
hildjj merged 2 commits intopeggyjs:mainfrom
hildjj:fix-466

Conversation

@hildjj
Copy link
Copy Markdown
Contributor

@hildjj hildjj commented Feb 11, 2024

Fixes #466.

@hildjj
Copy link
Copy Markdown
Contributor Author

hildjj commented Feb 11, 2024

@frostburn please review.

@frostburn
Copy link
Copy Markdown
Contributor

Looks good and got the project up and running on my end. 👍

Additional remarks

  1. It would be nice to link to CONTRIBUTING.md in README.md.
  2. After the setup described in this PR I got untracked files docs/package-lock.json and web-test/package-lock.json. These should be either included in the repository or added to .gitignore.
  3. It might've been npm run lint but docs/js/test-bundle.min.js ends up modified on my end according to git.

@hildjj
Copy link
Copy Markdown
Contributor Author

hildjj commented Feb 12, 2024

  1. willfix
  2. willfix, was playing with workspaces, but decided I didn't like them.
  3. I might not have checked in my last test fixes minified. willfix.

@hildjj hildjj merged commit d02bf1c into peggyjs:main Feb 12, 2024
@hildjj hildjj deleted the fix-466 branch February 12, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document project setup

2 participants