Unreachable code now causes a warning.#606
Merged
hildjj merged 3 commits intopeggyjs:mainfrom Apr 24, 2025
Merged
Conversation
Adds a "semantic" pass to the compiler, right before code generation, for rules that need to rely on node.match being in place, and depend on all other transformations having already run. Most of a fix for peggyjs#576, without full static analysis.
Mingun
reviewed
Apr 23, 2025
Member
Mingun
left a comment
Mingun
left a comment
There was a problem hiding this comment.
If I'm not missing something, you still need to do recursive call in visitor functions, otherwise you will catch problems only in the rule, but not inside ... / ..., for example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "semantic" pass to the compiler, right before code generation, for rules that need to rely on
node.match being in place, and depend on all
other transformations having already run.
Most of a fix for #576, without full static analysis.