[WIP] Restructure visitor.js for extensibility#642
Open
david-sharer wants to merge 5 commits intopeggyjs:mainfrom
Open
[WIP] Restructure visitor.js for extensibility#642david-sharer wants to merge 5 commits intopeggyjs:mainfrom
david-sharer wants to merge 5 commits intopeggyjs:mainfrom
Conversation
david-sharer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a tentative PR for this just so it can take comments.
-- so it also includes some of my other unrelated file changes.
-- and also needs to have some misc cleanup work done before merge.
All the existing tests appear to pass with the adapter subclass.
I don't have a ton of confidence in this structure yet.
First I want to try implementing some of my "Inner TypeScript Validation" tasks in it and see how it goes.
Discussed somewhat around here https://discord.com/channels/985995982909100082/985995983391440969/1393958574379765820
And the thread I opened on Inner TypeScript Validation https://discord.com/channels/985995982909100082/1393962299039027260