Skip to content

Conversation

Pepsiqqq
Copy link
Collaborator

@Pepsiqqq Pepsiqqq commented Sep 17, 2025

  1. The new flag, --force-pass-filepath, was added with a default value of false. This flag allows you to overwrite the pass file if it already exists.
  2. The --just-key flag now has a default value of true.
  3. Passing the --no-encryption flag will not result in an error if any other encryption flag is set. Those flags will be disabled, and the program will continue running.
  4. If verbose mode is selected (-v), and the --no-just-key flag is not specified, then the --just-key flag will be disabled.
  5. If the pass-filepath is provided password will only be output to the file, even if just-key flag is set

@Pepsiqqq Pepsiqqq marked this pull request as ready for review September 18, 2025 10:02
@svetasmirnova
Copy link
Collaborator

If the --pass-filepath flag is set, the password will still be printed in the output.

This is wrong. Reason to have --pass-filepath option is to do not print the password anywhere.

@Pepsiqqq
Copy link
Collaborator Author

If the --pass-filepath flag is set, the password will still be printed in the output.

This is wrong. Reason to have --pass-filepath option is to do not print the password anywhere.

Fixed

Copy link
Collaborator

@svetasmirnova svetasmirnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need to print password if we store it into the file. This is the purpose of the file: do not show password on the terminal.

Also, all code needs to be covered by tests.

@svetasmirnova svetasmirnova merged commit dace09c into percona:main Sep 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants