-
Notifications
You must be signed in to change notification settings - Fork 23
Add perses-operator libsonnet #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Saswata Mukherjee <[email protected]>
|
cc: @simonpasquier |
simonpasquier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we convert the perses*-crd.json from config/crd/bases using gojsontoyaml?
Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
|
@simonpasquier ok I kind of tried a trick here. I basically converted all the kubebuilder generated YAML to json in jsonnet dir, then import and modify those. So any future edits of the original kubebuilder YAML would reflect into the jsonnet lib. Let me know if this seems reasonable, cc: @jgbernalp |
simonpasquier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we highlight generated files more prominently? Either .json files go to jsonnet/enerated/ or we add some header to the json files?
Also I'm not sure that we need to keep the manifests generated from jsonnet in the repository since they kinda overlap with the manifest files.
One last thing: it would be good to run jsonnetfmt on the json/jsonnet files.
|
@simonpasquier I added fmt and linting for jsonnet. As for the manifests generated by jsonnet, I would still like to keep them, as you can test those manifests on a cluster and validate that things work as expected. |
Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
simonpasquier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit adds a jsonnet lib to perses operator, so that the CRDs and definitions can be imported by downstream stacks like kube-prometheus