Skip to content

Fix #101: add missing attribute for department, make required #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2022
Merged

Fix #101: add missing attribute for department, make required #102

merged 1 commit into from
Mar 7, 2022

Conversation

mdbenito
Copy link
Contributor

@mdbenito mdbenito commented Feb 26, 2022 •
edited
Loading

This PR adds the missing id field to the attributes of Department and makes both id and name required to enable better typing in generated code. Since Departments are only returned by the API this shouldn't break any dependent code.

Closes #101

@mdbenito
Copy link
Contributor Author

mdbenito commented Mar 5, 2022

@oleglfed Thanks for reviewing! Maybe you have time to check out #103 as well?

@ypasmk ypasmk merged commit 70d05bd into personio:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleglfed oleglfed oleglfed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mismatch between documented type for Department and returned data
3 participants
@mdbenito @oleglfed @ypasmk