Skip to content

Jupyterlab-phosphor should not attempt to load empty array #742

@timkpaine

Description

@timkpaine

https://github.com/finos/perspective/blob/master/packages/perspective-phosphor/src/ts/widget.ts#L319

This code should be

if (Array.isArray(data)) 
    if (data.length > 0{
        if (this._wrap) {
            this.pspNode.update([data]);
        } else {
            this.pspNode.update(data);
        }
    } else {
        console.warn('Perspective received length 0 data');
    }
} else {
...

Metadata

Metadata

Assignees

No one assigned

    Labels

    JSJupyterbugConcrete, reproducible bugs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions