Skip to content

Spelling and grammar corrections #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
texodus merged 2 commits into from
Jun 24, 2020
Merged

Spelling and grammar corrections #1094

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca6e307
Spelling and grammar corrections
Shubham-1999 Jun 19, 2020
db965be
2 space removed
Shubham-1999 Jun 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/md/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,10 @@ installed in a Docker container.
The Puppeteer/UI tests are a form of
[characterization tests](https://en.wikipedia.org/wiki/Characterization_test)
which use screenshots to compare current and previous behavior of
`<perspective-viewer>` and its plugins. The results of the each comparison are
`<perspective-viewer>` and its plugins. The results of each comparison are
Copy link
Member

@timkpaine timkpaine Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 spaces here

Copy link
Contributor Author

@Shubham-1999 Shubham-1999 Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed spaces.

stored in each package's `test/results/results.json` file, and the screenshots
themselves are stroed in the package's `screenshots/` directory, though only the
former should be checked in to GIT. When a test in these suites fails, a
themselves are stored in the package's `screenshots/` directory, though only the
former should be checked into GIT. When a test in these suites fails, a
`file.failed.png` and `file.diff.png` are also generated, showing the divergent
screenshot and a contrast diff respectively, so you can verify that the changed
behavior either does or does not reflect your patch. If you're confident that
Expand Down Expand Up @@ -282,7 +282,7 @@ that the benchmark suite will run, where `<NUMBER>` is an integer greater
than 0. If `<NUMBER>` cannot be parsed, is 0, or is greater than the number of
versions, the benchmark suite will run all previous versions of Perspective.

The benchmarks report and `results.json` show a historgram of current
The benchmarks report and `results.json` show a histogram of current
performance, as well as that of the previous `results.json`. Running this should
probably be standard practice after making a large change which may affect
performance, but please create a baseline `results.json` entry for your test
Expand Down