Conversation
This was referenced Jun 21, 2020
Merged
timkpaine
approved these changes
Jun 21, 2020
Member
timkpaine
left a comment
timkpaine
left a comment
There was a problem hiding this comment.
looks like some autoformatting is making the diff huge
Contributor
Author
|
@timkpaine all the PRs need to go on top of manylinux and CRLF fix - I couldn’t do any local development without fixing CRLF first |
Member
|
Looks good! Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BOOST_ROOTon Azure win64 got moved one level down intoBoost/1.69.0/x86_64, which is breaking Azure builds.This branch is on top of #1082 - that should be good to merge without doing a rebuild/re-CI, which would fail without this patch.