Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<perspective-viewer>'s current plugin API is implemented via a configuration object literal, registered via a global registration callback functionregisterPlugin(). Some deficiencies of this design include:plugin_configattribute in public API.@finos/perspective-viewer-datagrid, developers must endure a complex setup of awaiting the plugin to render in order to customize it.This PR refactors the plugin API to use Custom Elements, rather than configuration object literals, as the plugin template. Plugin Custom Elements reside as the
<perspective-viewer>'s light DOM children, which makes it convenient for plugins to expose their own APIs. For example, The<perspective-viewer-debug>element, which just renders theViewas a CSV non-virtually here, and has this basic framework:which can be customized at runtime like so:
Other effects of this PR include:
typeandnamehave been replaced by justname; e.g.,"x_bar"type is now"X Bar", thenameplugin property. Docs, examples, python, etc have been updated to reflect this.