Skip to content

Cleanup up python requirements installation in CI, remove some dangling azure references, refresh python README#1917

Merged
texodus merged 3 commits intomasterfrom
tkp/requires
Jul 29, 2022
Merged

Cleanup up python requirements installation in CI, remove some dangling azure references, refresh python README#1917
texodus merged 3 commits intomasterfrom
tkp/requires

Conversation

@timkpaine
Copy link
Member

@timkpaine timkpaine commented Jul 25, 2022

  • removing bespoke package installs/runs in the github actions script (python dependencies and pytest configuration)
    • fixes the very correct complaints in Fix publish issues #1915 (comment) namely, dependencies are derived from a single source of truth that is the setup.py
    • dependencies can still break our CI process, but these should be legitimate breakages of compatibility where a dependency has triggered an incompatibility at run time, rather than some stale hardcoding of a version of dependency in a CI script at ci time
  • Remove python readme as it is trivial for it to become stale, instead pull main README during python build/packaging
  • Remove azure references from package.json, remove azure build script
  • add python 3.10 pypi classifier
  • remove .artifactignore azure config file
  • add tornado pin < 6.2
  • add jupyterlab pin < 4
  • add conda installation instructions to python docs
  • cleanup some typos and unclear stuff in python docs
  • redo of remove separate mock dependency, now part of unittest #1827 now that the docker images are gone (cherry pick from remove separate mock dependency, now part of unittest - fixes #1821 #1925)
  • MacOS 10.15 has been long deprecated by GItHub and our CI is failing currently due to brownout.

@timkpaine timkpaine added the internal Internal refactoring and code quality improvement label Jul 25, 2022
@timkpaine timkpaine force-pushed the tkp/requires branch 3 times, most recently from ecd36ac to fa7f846 Compare July 25, 2022 21:43
@timkpaine timkpaine marked this pull request as ready for review July 25, 2022 22:34
@timkpaine timkpaine requested a review from texodus July 25, 2022 22:36
@timkpaine
Copy link
Member Author

@texodus should trigger a full build so we can verify that grep works on windows 😅

@timkpaine timkpaine force-pushed the tkp/requires branch 5 times, most recently from 6ff3bc5 to e7e60a0 Compare July 28, 2022 00:34
…ng azure references, refresh python README, add conda badge
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus mentioned this pull request Jul 29, 2022
@texodus
Copy link
Member

texodus commented Jul 29, 2022

Adding #1924 also

@texodus texodus merged commit 590000a into master Jul 29, 2022
@texodus texodus deleted the tkp/requires branch July 29, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal refactoring and code quality improvement

Development

Successfully merging this pull request may close these issues.

2 participants