Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"parser": "babel-eslint",
"plugins": ["markdown", "prettier"],
"env": {
"browser": true,
Expand All @@ -10,7 +9,7 @@
"jest": true
},
"parserOptions": {
"ecmaVersion": 2017,
"ecmaVersion": 2020,
"ecmaFeatures": {},
"sourceType": "module",
"experimentalObjectRestSpread": true
Expand Down
2 changes: 1 addition & 1 deletion examples/blocks/src/streaming/streaming.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,6 @@ window.addEventListener("DOMContentLoaded", async function () {
// Add more rows every 50ms using the `update()` method on the `table` directly.
(function postRow() {
table.update(newRows());
setTimeout(postRow, 50);
setTimeout(postRow, 10);
})();
});
14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,9 @@
"@babel/core": "^7.8.4",
"@babel/preset-env": "^7.8.4",
"@types/ws": "^7.2.2",
"@typescript-eslint/eslint-plugin": "^4.31.0",
"@typescript-eslint/eslint-plugin": "^5.33.1",
"@typescript-eslint/parser": "^4.31.0",
"arraybuffer-loader": "^1.0.2",
"babel-eslint": "^10.0.3",
"babel-jest": "^25.1.0",
"chalk": "^2.4.2",
"cpy-cli": "^3.1.1",
Expand All @@ -45,10 +44,10 @@
"dotenv": "^8.1.0",
"esbuild": "^0.13.12",
"esbuild-plugin-less": "^1.1.5",
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-markdown": "^2.2.0",
"eslint-plugin-prettier": "^4.0.0",
"eslint": "^8.22.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-markdown": "^3.0.0",
"eslint-plugin-prettier": "^4.2.1",
"fs-extra": "^8.1.0",
"html-loader": "^0.5.1",
"html-loader-jest": "^0.2.1",
Expand All @@ -71,12 +70,13 @@
"octokit": "^1.7.2",
"postcss": "^8",
"postcss-loader": "^7",
"prettier": "^2.4.0",
"prettier": "^2.7.1",
"puppeteer": "^13.1.3",
"rimraf": "^2.6.2",
"sinon": "^7.3.1",
"style-loader": "^0.18.2",
"term-img": "^4.1.0",
"tiny-glob": "^0.2.9",
"ts-loader": "^6.2.0",
"typedoc": "^0.22.7",
"typedoc-plugin-markdown": "^3.11.6",
Expand Down
24 changes: 12 additions & 12 deletions packages/perspective-workspace/src/js/workspace/workspace.js
Original file line number Diff line number Diff line change
Expand Up @@ -350,11 +350,11 @@ export class PerspectiveWorkspace extends SplitPanel {
if (master || this.mode === MODE.LINKED) {
widget.viewer.addEventListener(
"perspective-select",
this.onPerspectiveSelect
this.onPerspectiveSelect.bind(this)
);
widget.viewer.addEventListener(
"perspective-click",
this.onPerspectiveSelect
this.onPerspectiveSelect.bind(this)
);
// TODO remove event listener
this.masterPanel.addWidget(widget);
Expand Down Expand Up @@ -534,7 +534,7 @@ export class PerspectiveWorkspace extends SplitPanel {
await viewer.restore({filter: newFilters});
}

onPerspectiveSelect = async (event) => {
async onPerspectiveSelect(event) {
const config = await event.target.save();
// perspective-select is already handled for hypergrid

Expand Down Expand Up @@ -562,7 +562,7 @@ export class PerspectiveWorkspace extends SplitPanel {
this._filterViewer(widget.viewer, filters, candidates)
);
}
};
}

async makeMaster(widget) {
widget.master = true;
Expand All @@ -582,11 +582,11 @@ export class PerspectiveWorkspace extends SplitPanel {
widget.viewer.restyleElement();
widget.viewer.addEventListener(
"perspective-click",
this.onPerspectiveSelect
this.onPerspectiveSelect.bind(this)
);
widget.viewer.addEventListener(
"perspective-select",
this.onPerspectiveSelect
this.onPerspectiveSelect.bind(this)
);
}

Expand All @@ -605,11 +605,11 @@ export class PerspectiveWorkspace extends SplitPanel {
widget.viewer.restyleElement();
widget.viewer.removeEventListener(
"perspective-click",
this.onPerspectiveSelect
this.onPerspectiveSelect.bind(this)
);
widget.viewer.removeEventListener(
"perspective-select",
this.onPerspectiveSelect
this.onPerspectiveSelect.bind(this)
);
}

Expand Down Expand Up @@ -971,7 +971,7 @@ export class PerspectiveWorkspace extends SplitPanel {
widget.viewer.addEventListener("perspective-config-update", updated);
widget.viewer.addEventListener(
"perspective-plugin-update",
this.workspaceUpdated
this.workspaceUpdated.bind(this)
);

widget.title.changed.connect(updated);
Expand All @@ -987,7 +987,7 @@ export class PerspectiveWorkspace extends SplitPanel {
);
widget.viewer.removeEventListener(
"perspective-plugin-update",
this.workspaceUpdated
this.workspaceUpdated.bind(this)
);
widget.title.changed.disconnect(updated);
});
Expand Down Expand Up @@ -1021,7 +1021,7 @@ export class PerspectiveWorkspace extends SplitPanel {
}
}

workspaceUpdated = () => {
async workspaceUpdated() {
if (!this._save) {
this._save = debounce(
() =>
Expand All @@ -1031,5 +1031,5 @@ export class PerspectiveWorkspace extends SplitPanel {
);
}
this._save();
};
}
}
Loading