let themes control select and option colors#2400
let themes control select and option colors#2400wjackson wants to merge 1 commit intoperspective-dev:masterfrom
Conversation
|
Thanks for the PR @wjackson! Adding new CSS variables for these properties requires this variable to be specified for all themes, as you've noticed. As there is not compelling reason to style option background in isolation, this shouldn't be public (or at the very least, should default to the themes' palette). I can't test this as its a Windows bug (not a Chrome bug as the Issue says), but I've added this default in #2422 anyway, closing |
Yeah that makes sense.
The screenshots in #2369 came from Chrome on Linux so it's not a Windows bug. As mentioned in the issue, I tested for and found the bug on a couple different Linuxes and Windows. I tested your fix ( |
This is a fix for #2369.