Update toolchain, and update macro metavar syntax #2621
Closed
tomjakubowski wants to merge 2 commits intoperspective-dev:masterfrom
Closed
Update toolchain, and update macro metavar syntax #2621tomjakubowski wants to merge 2 commits intoperspective-dev:masterfrom
tomjakubowski wants to merge 2 commits intoperspective-dev:masterfrom
Conversation
tomjakubowski
force-pushed
the
bugfix/macro-usage
branch
from
b44b50c to
1278117
Compare
The syntax change is needed for perspective to compile on newer toolchains the relevant rust repo change is here: rust-lang/rust@0278505 Signed-off-by: Tom Jakubowski <tom@prospective.dev>
Signed-off-by: Tom Jakubowski <tom@prospective.dev>
tomjakubowski
force-pushed
the
bugfix/macro-usage
branch
2 times, most recently
from
cf9e617 to
e4b1003
Compare
Merged
Member
|
Thanks for the PR! I've cherry-picked this into #2623, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The syntax change is needed for perspective to compile on newer toolchains
the relevant rust repo change is here:
rust-lang/rust@0278505
I also updated some code to address new lints from the toolchain update, in a separate commit for readability