Document llvm@17 usage on Homebrew#2622
Closed
tomjakubowski wants to merge 1 commit intoperspective-dev:masterfrom
Closed
Document llvm@17 usage on Homebrew#2622tomjakubowski wants to merge 1 commit intoperspective-dev:masterfrom
tomjakubowski wants to merge 1 commit intoperspective-dev:masterfrom
Conversation
tomjakubowski
commented
May 17, 2024
| } | ||
| } | ||
|
|
||
| const CLANG_TIDY_PATH = fs.existsSync(`${__dirname}/../../.llvm`) |
Contributor
Author
There was a problem hiding this comment.
My observation was that run-clang-tidy failed unless clang-tidy was also on the PATH. So I had to add .llvm/bin to the PATH anyway to get it to build, making this logic redundant
Contributor
Author
There was a problem hiding this comment.
(in CI, see also the comment in the .yml file - llvm 17 is put on the PATH)
timkpaine
reviewed
May 17, 2024
Signed-off-by: Tom Jakubowski <tom@prospective.dev>
tomjakubowski
force-pushed
the
bugfix/llvm-clang-tidy-usage
branch
from
99039e9 to
a6ae54d
Compare
Merged
Member
|
Thanks for the PR! I've cherry-picked this into #2623, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add to developer docs, sprinkle a comment in CI, update the lint script