Better Timestamp Parsing#2713
Merged
texodus merged 2 commits intoperspective-dev:masterfrom Aug 23, 2024
Merged
Conversation
sinistersnare
force-pushed
the
feature/better-timestamp-parsing
branch
from
414ec7f to
675272a
Compare
Signed-off-by: Davis Silverman <davis@thedav.is>
TZs were being handled backward by the parser, and now we also support Timezones after the fractional second part. Perspective still only supports milliseconds internally, so this only parses them correctly, but truncates their values to millisecond precision. Signed-off-by: Davis Silverman <davis@thedav.is>
sinistersnare
force-pushed
the
feature/better-timestamp-parsing
branch
from
675272a to
bdabded
Compare
texodus
approved these changes
Aug 23, 2024
Member
texodus
left a comment
texodus
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good!
Outstanding test coverage!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR improves the parsing of timestamp strings in Perspective! It also improves our Timezone parsing logic to better support strange timezones (like Nepal, Myanmar, or Mars). This PR also adds a few tests, so I hope that you have a good day and can sleep more restfully with this in mind.
Thanks!