[WIP] Merging JS and Python binding code - Part 2#389
Merged
texodus merged 12 commits intoperspective-dev:masterfrom Jan 23, 2019
Merged
[WIP] Merging JS and Python binding code - Part 2#389texodus merged 12 commits intoperspective-dev:masterfrom
texodus merged 12 commits intoperspective-dev:masterfrom
Conversation
timkpaine
changed the title
Member
|
Thanks for the PR! This is a great step towards unifying these APIs - I have some anxiety about exposing the C++ types directly, and this helps alot as @sc1f continues to remove this functionality on the JS side, making it easy to extend it on the Python side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.