Added "Multi Chart" that allows mix-and-match of different series types#586
Closed
andy-lee-eng wants to merge 5 commits intoperspective-dev:masterfrom
Closed
Added "Multi Chart" that allows mix-and-match of different series types#586andy-lee-eng wants to merge 5 commits intoperspective-dev:masterfrom
andy-lee-eng wants to merge 5 commits intoperspective-dev:masterfrom
Conversation
Initially just does line and bar series. Refactored to allow re-use of line/bar specific data and series code Refactored to increase flexibility of chart and splitter functionality
Legend position is preserved when the chart structure changes.
andy-lee-eng
force-pushed
the
feature/mix-chart
branch
from
ee7678d to
a3ca216
Compare
andy-lee-eng
changed the base branch from
DevAndyLee-feature/dual-y-other-charts
to
master
Contributor
Author
|
Rebased on |
|
This looks pretty slick. Wondering if there are plans to push this through? Seems like the PR it was waiting on has been merged. |
|
this is a useful , having multi type chart . Will it be available soon ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a PoC and depends on PR #581. I thought I'd offer it this way so you can get a look at it and provide any feedback. Once #581 has been completed, we can re-do this as a PR into master.
The "Multi Chart" behaves much like the "Y Bar Chart", "Y Line Chart", "Y Area Chart" and "Y Scatter Chart", but can use series types from any of the above.
Notice the line/bar chart icons underneath the two y-axes. Clicking on them will cycle through the available series types for that axis (line/bar/area/scatter). The chosen series types will be remembered in "settings" if you save and load.
This chart reproduces a lot of the features of the other 4 charts (though is not quite identical), so I'm not sure how best to introduce it. Matt suggested maybe we could get rid of the other 4 charts, and provide a mapping function to this chart. For example, if someone is restoring a saved "Y Line Chart", we could instead show a "Multi Chart" with the "line" series selected.