Change: Add title to perspective rows#619
Change: Add title to perspective rows#619quigleyj-mavenomics wants to merge 1 commit intoperspective-dev:masterfrom
Conversation
Very long column names (which you might get from a join) tend to be cut off in the column view. This adds a 'title' attribute so that they are at least visible in an accessible way on hover.
|
Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@quigleyj-mavenomics). In order for your PR to be reviewed and merged, please follow the directions at the link above. Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above. If you still have any questions or just don't know what to do next, please email help@finos.org. /CC @finos-admin |
|
FYI, I concurrently e-mailed in the FINOS CCLA (covering Joe Quigley's contribution and perhaps more to come in the future!) |
|
@finos-cla-bot[bot] check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Thanks for the PR! @quigleyj-mavenomics unfortunately we've encountered some disruption with this implementation - specifically, it is common to override the context menu ala in Jupyterlab, and the title hover floats over the DOM-implemented context menu. I've just pushed #650 which makes the left panel resizable on drag - hopefully this addresses the issue for you. If not, I can merge this patch with the caveat that I'll need to make this optional (and disabled by default likely). |
|
That works for us! Having the drag-resize should address our need a lot better, especially since we have one dataset in particular with quite a few long-named columns. |
|
Groovy, I will have this disted in 0.3.2 tomorrow. |
|
I have a related question - is it possible to provide a column header or "pretty name" in addition to the column id? this may also help cope with long column names. |
Very long column names (which you might get from a join) tend to be cut off in the column view. Currently there isn't a way to see what the full column name is, without adding it to a grid view and looking at the column header.
Example:
With this change, they will now display a browser-native tooltip on mouse hover. This is more a stopgap/workaround than a solution, but it's not disruptive.