Allow for perspective in ipywidgets layouts#702
Merged
Conversation
Member
Author
vidartf
reviewed
Sep 3, 2019
vidartf
left a comment
vidartf
left a comment
There was a problem hiding this comment.
Looks good in principle. Added some comments that might make it a little cleaner.
|
|
||
| _setElement(el: HTMLElement) { | ||
| if (this.el || el !== this.pWidget.node) { | ||
| // Accordions don't allow setting the element beyond the initial creation. |
|
|
||
| this.displayed.then(()=> { | ||
| this.psp._render(); | ||
| (this.pWidget as PerspectiveWidget)._render(); |
There was a problem hiding this comment.
Would be cleaner to override the declaration of pWidget for this class:
pWidget: PerspectiveWidget;| key?: string; | ||
| wrap?: boolean; | ||
| delete_?: boolean; | ||
| view?: any; |
There was a problem hiding this comment.
Note that it is also possible to extend PerspectiveWidget adding the view options similar to how JupyterPhosphorAccordionWidget does this in @jupyter-widgets/controls.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #694 without breaking in normal view
top: perspective in
ipywidgets.HBoxbottom: normal