Skip to content

Allow missing columns#881

Merged
texodus merged 5 commits intomasterfrom
allow-missing-columns
Feb 2, 2020
Merged

Allow missing columns#881
texodus merged 5 commits intomasterfrom
allow-missing-columns

Conversation

@texodus
Copy link
Member

@texodus texodus commented Jan 27, 2020

A new column-selection widget for @finos/perspective-viewer which allows columns to be "missing" for fields if the selected plugin specifies it, as well as implementing selected column locking for X/Y chart types which need more than one axis.

With this change, D3FC XY Scatter, Y Scatter, Treemap, Sunburst, Y Line all support optional arguments and 0-N tooltip columns, and the columns attribute of perspective-viewer may now contain null where supported by the plugin (and ignored otherwise).

new_col_selector

@texodus texodus requested a review from zemeolotu January 27, 2020 07:46
@texodus texodus force-pushed the allow-missing-columns branch from cda8abf to 48607bd Compare January 27, 2020 15:00
@timkpaine timkpaine added enhancement Feature requests or improvements JS labels Jan 28, 2020
@texodus texodus force-pushed the allow-missing-columns branch from 48607bd to b1f4729 Compare February 1, 2020 23:29
@texodus texodus force-pushed the allow-missing-columns branch from b1f4729 to 4d8325c Compare February 2, 2020 00:12
@texodus texodus merged commit 3c03352 into master Feb 2, 2020
@texodus texodus deleted the allow-missing-columns branch February 2, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature requests or improvements JS

Development

Successfully merging this pull request may close these issues.

3 participants