Fix bug where perspective-viewer doesn't resize#911
Merged
Conversation
texodus
reviewed
Feb 8, 2020
Member
There was a problem hiding this comment.
This was supposed to return false because _pre_resize() above it itself calls this.plugin.resize() here, thus preventing resize logic form being applied twice. Clearly that's not working correctly but I believe returning true here will render the plugin twice?
Contributor
Author
There was a problem hiding this comment.
Gotcha, however pre_resize() isn't actually called in that block. Is the right fix to just call pre_resize then?
Member
|
Thanks for the PR! I believe this is fixed in #914 |
Member
|
Thank for the PR! I misread this in review, apologies! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.