Merged
Conversation
Member
|
That makes sense - an immutability problem. Well, using an immutable value for this if we're modifying its contents concurrently makes sense. Let's give that a try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #90
Not sure if this is related, but due to
ConcurrentDictionary.AddOrUpdatespecific internal hashset could be populated with some threading issues.Other way could be to just throw away
Parallel.ForEachhere, but... Lets try this update first.P.S. NRE is caused by the fact that some of the elements of this hashset is
null. Each element is taken directly fromprojectFile, which not be null by itself (it is created just before passing toFindProjectImportsmethod, and used several times before adding it to hashset).So, the only weak place is adding to hashset, and since
updateValueFactoryis executed byConcurrentDictionarywithout thread lock, this may give some issues. Do not see relation with NRE, but this is only place I can fix here.