Skip to content

Conversation

@dpxcc
Copy link
Contributor

@dpxcc dpxcc commented Mar 1, 2025

Currently

#[pg_extern(sql = "
CREATE FUNCTION xxx_handler(internal) RETURNS table_am_handler LANGUAGE C STRICT AS 'MODULE_PATHNAME';
CREATE ACCESS METHOD xxx TYPE TABLE HANDLER xxx_handler;
")]
fn xxx_handler(_fcinfo: pg_sys::FunctionCallInfo) -> PgBox<pg_sys::TableAmRoutine> {
    let mut amroutine =
        unsafe { PgBox::<pg_sys::TableAmRoutine>::alloc_node(pg_sys::NodeTag::T_TableAmRoutine) };

    ...

    amroutine.into_pg_boxed()
}

throws error saying that SqlTranslatable is not implemented for TableAmRoutine

@dpxcc dpxcc changed the title Implemenet SqlTranslatable for TableAmRoutine Implement SqlTranslatable for TableAmRoutine Mar 1, 2025
Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eeeebbbbrrrr eeeebbbbrrrr merged commit 4d3ca8f into pgcentralfoundation:develop Mar 1, 2025
14 checks passed
KenjiBrown pushed a commit to SoftwareLibreMx/pgrx that referenced this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants