Elide needless lifetime #2097
Merged
Elide needless lifetime #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used clippy to find `clippy::needless_lifetimes` and fix them
eeeebbbbrrrr
approved these changes
Jun 29, 2025
eeeebbbbrrrr
added a commit
that referenced
this pull request
Aug 1, 2025
Welcome to pgrx v0.16.0. This release contains support for Postgres 18beta2 and has some breaking changes in that support for pgrx' "hooks" implementation, which has been deprecated for over a year, has finally been removed. Additionally, due to unsoundness issues, direct support for using `heapless` in shared memory has been removed. Users can still do this themselves, which requires them to assert they're taking responsibility of possible unsoundness issues. As always, first install the latest `cargo-pgrx` with: ```shell $ cargo install cargo-pgrx --version 0.16.0 --locked ``` Then you're free to run `cargo pgrx upgrade` in the root of all your extension crates. To pickup pg18beta2 support you'll also want to run `cargo pgrx init` so that it can be downloaded and compiled. # What's Changed ## Breaking Changes * delete `pgrx::hooks` by @usamoi in #2120 * improve shmem api by @usamoi in #2107 ## New Features * update to Postgres v18beta2 by @usamoi in #2111 * feat: `BackgroundWorker::connect_worker_to_spi_by_oid` by @if0ne in #2116 * teach `#[pg_cast]` to support 3-argument CAST functions by @eeeebbbbrrrr in #2119 * teach `#[pg_extern]` about a SUPPORT function by @eeeebbbbrrrr in #2121 ## Bug Fixes * fix name_data_to_str by @usamoi in #2108 * add pg_guard_ffi_boundary to direct_pg_extern_function_call_as_datum by @usamoi in #2118 ## `cargo-pgrx` Improvements * add `--valgrind` to more cargo-pgrx subcommands by @usamoi in #2109 * `cargo pgrx regress --resetdb` will run `setup.sql` by @ccleve in #2113 ## Code Cleanup * filter out unrecognized attributes in PostgresGucEnum by @usamoi in #2102 * Elide needless lifetime by @nyurik in #2097 ## Package/Build System Cleanup * chore: include pgrx-version-updater into workspace by @nyurik in #2101 * chore: consolidate package settings in workspace by @nyurik in #2100 * chore: prepare for 2024 edition by @nyurik in #2103 # Thanks! Thanks to all contributors -- y'alls work helps keep pgrx moving forward. **Full Changelog**: v0.15.0...v0.16.0
workingjubilee
added a commit
to workingjubilee/pgrx
that referenced
this pull request
Oct 28, 2025
This reverts commit 64f31ea.
workingjubilee
added a commit
to workingjubilee/pgrx
that referenced
this pull request
Oct 28, 2025
This reverts commit 64f31ea.
workingjubilee
added a commit
to workingjubilee/pgrx
that referenced
this pull request
Oct 28, 2025
Partially reverts commit 64f31ea
workingjubilee
added a commit
that referenced
this pull request
Oct 28, 2025
These were removed in #2097 but some instances wound up erasing deliberate, meaningful names for lifetimes. Eliding them as technically-meaningless at some use-sites is unhelpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used clippy to find
clippy::needless_lifetimesand fix themLet's try this again