cargo-pgrx: fix pg_regress path inconsistency #2137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
wow that was fast :) Thanks a lot ! |
Contributor
|
@charmitro : Don't ignore the .gitignore file ;-) cargo-pgrx/src/templates/gitignore |
The 'cargo pgrx new' command was creating pg_regress directories at the project root (./pg_regress/), while 'cargo pgrx regress' expected them under the tests directory (./tests/pg_regress/). This inconsistency caused immediate failures when running regression tests on newly created projects. Fix the path mismatch by updating 'cargo pgrx new' to create the pg_regress directory structure under tests/, aligning with where 'cargo pgrx regress' expects to find them. This follows Rust's convention of organizing test files in a tests/ directory. Also update the documentation and the hooks example to use the consistent path structure. Fixes: pgcentralfoundation#2136 ("Inconsistencies in the pg_regress path") Signed-off-by: Charalampos Mitrodimas <[email protected]>
charmitro
force-pushed
the
regress-path-inconsistency
branch
from
48676d5 to
44d0966
Compare
Contributor
Author
Oops, done! |
eeeebbbbrrrr
added a commit
that referenced
this pull request
Sep 25, 2025
Welcome to pgrx v0.16.1. This is a relatively minor release but does add support for Postgres v18, released on September 25, 2025. As always, install/update `cargo-pgrx` with `cargo install cargo-pgrx --version 0.16.1 --locked`. Then run `cargo pgrx update` in all your extension crates. To pick up Postgres v18, you'll need to run (at least) `cargo pgrx init` and then add the `pg18` feature flag to your extension's `Cargo.toml`. ## What's Changed * remove polyfill crates by @usamoi in #2128 * Example : register PostgreSQL hooks by @daamien in #2125 * add more WAL/replication headers by @eeeebbbbrrrr in #2130 * remove home, supports-color 0.2 and update toml, color-eyre by @usamoi in #2133 * cargo-pgrx: fix pg_regress path inconsistency by @charmitro in #2137 * fix big endian by @usamoi in #2132 * Fixing CI by @eeeebbbbrrrr in #2143 * pg18 support by @eeeebbbbrrrr in #2144 **Full Changelog**: v0.16.0...v0.16.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'cargo pgrx new' command was creating pg_regress directories at the project root (./pg_regress/), while 'cargo pgrx regress' expected them under the tests directory (./tests/pg_regress/). This inconsistency caused immediate failures when running regression tests on newly created projects.
Fix the path mismatch by updating 'cargo pgrx new' to create the pg_regress directory structure under tests/, aligning with where 'cargo pgrx regress' expects to find them. This follows Rust's convention of organizing test files in a tests/ directory.
Also update the documentation and the hooks example to use the consistent path structure.
Fixes: #2136 ("Inconsistencies in the pg_regress path")