Add support to decode enums and other types as String
#454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no immediately suitable codec can be found and the request is to decode as a String, then fallback to using the VARCHAR codec. [pgjdbc#429]
Automatically register an EnumStringCodec and an EnumStringArrayCodec for enums. [pgjdbc#429]
|
It would be great if this could be back ported to 0.8.x as well |
mp911de
changed the title
String
|
Thanks for your pull request. I'm going to generalize decoder support to fall back onto a codec that simply decodes the payload when no other codec was found. That simplifies the arrangement because it doesn't require any application configuration regarding enum codecs. |
mp911de
pushed a commit
that referenced
this pull request
Oct 26, 2021
mp911de
pushed a commit
that referenced
this pull request
Oct 26, 2021
mp911de
added a commit
that referenced
this pull request
Oct 26, 2021
Refactor enum to string codecs into StringDecoder and StringArrayDecoder as fallback codecs if no other codec could be found. Allow reuse of ArrayCodec. [#454][resolves #454] Signed-off-by: Mark Paluch <[email protected]>
|
Thank you for your contribution. That's merged, polished, and backported now. |
mp911de
added a commit
that referenced
this pull request
Oct 26, 2021
Refactor enum to string codecs into StringDecoder and StringArrayDecoder as fallback codecs if no other codec could be found. Allow reuse of ArrayCodec. [#429][resolves #454] Signed-off-by: Mark Paluch <[email protected]>
mp911de
added a commit
that referenced
this pull request
Oct 26, 2021
Refactor enum to string codecs into StringDecoder and StringArrayDecoder as fallback codecs if no other codec could be found. Allow reuse of ArrayCodec. [#429][resolves #454] Signed-off-by: Mark Paluch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
Issue description
Fixes (or at least makes progress towards) #429