Repository navigation
statsd_prefix ignored from non-cli option config #382
Description
statsd_prefix can only be set via the command line and does not work if set within hypercorn_config.py. Tested on version 0.18.0 (haven't tested on main but I think I see the cause and it's not fixed).
In src/hypercorn/__main__.py at line
hypercorn/src/hypercorn/__main__.py
Line 185 in 0e2311f
argparse.ArgumentParser has default="". This is the only non-list arg to have a non-sentinel default, and later at hypercorn/src/hypercorn/__main__.py
Line 288 in 0e2311f
sentinel but can never have been set to it.
Fix is to change the arg's default from "" to sentinel.
Activity