Improved typehint for method 'View::render' #16768
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raicabogdan
approved these changes
May 28, 2025
Contributor
|
Can you also add a change log? |
Contributor
|
And also target |
Member
|
@kuhler-Stratege Can you please rebase this to target the 5.0.x branch? |
Member
Well what @raicabogdan wrote :) |
niden
requested changes
Jun 2, 2025
Member
niden
left a comment
niden
left a comment
There was a problem hiding this comment.
Please rebase your branch to 5.0.x
kuhler-Stratege
force-pushed
the
view-render-typehint
branch
from
90331fb to
f26954d
Compare
niden
approved these changes
Jun 5, 2025
Member
|
Thank you @kuhler-Stratege |
niden
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
I noticed that the method
View::renderhas a typehint ofView|bool. The method never returnstrueso I changed the return type toView|false.Change log:
Changed the return type of the method
View::rendertoView|false.Thanks