general cleanup #184
general cleanup #184
Conversation
tjheffner
requested review from
anniegreens,
illepic,
madhaze,
jryanconklin and
rloos289
| @@ -10,6 +10,18 @@ | |||
| "dark": "rgb(52, 58, 64)", | |||
| "test": "rgb(255, 192, 203)" | |||
| }, | |||
| "scssBreakpoints": { | |||
There was a problem hiding this comment.
Nice. If we update this in the grid component, this will update correct?
There was a problem hiding this comment.
these values are coming from bootstrap's $grid-breakpoints(). if needed, they would get overridden probably inside of _variables.scss, similar to how we are able to override $theme-colors()
| @import 'forms'; | ||
| @import 'tables'; | ||
| @import 'transitions'; | ||
| @import 'printing/type'; |
There was a problem hiding this comment.
This is much clearer. Thank you!
| @@ -0,0 +1,37 @@ | |||
| /// | |||
There was a problem hiding this comment.
Are we going to aim to have this more fully documented on the front end docs project?
There was a problem hiding this comment.
yes. this is mostly a companion to the large comment in _base.scss, the other "main" sass file, to hopefully really underscore the printing/nonprinting difference. that distinction should/will be covered thoroughly in the FE docs
| m: 25px, | ||
| l: 50px, | ||
| ); | ||
|
|
There was a problem hiding this comment.
Comment right here that this is where we can override bootstrap variables (that aren't just overriden in a component later on).
what i could pull back from msk:
should hit some parts/all of these issues:
#177
#169
#157
#125 [this issue desc. should get copied into docs]
#155