Skip to content

Auto-inject import sass variables #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2018
Merged

Auto-inject import sass variables #352

merged 3 commits into from
Aug 30, 2018

Conversation

illepic
Copy link
Contributor

@illepic illepic commented Aug 30, 2018

Handles: #351

illepic added 2 commits August 30, 2018 08:47
@illepic
Inject '@import 00-protons/variables to all sass files. Also, provide…
2a396fc 
… includePaths so all Sass can use short import statements.
@illepic
Update yeoman generator with new auto-injection language, update PL s…
da5c2fa 
…ass to assume variables is available
@illepic illepic self-assigned this Aug 30, 2018
@illepic illepic requested a review from a team August 30, 2018 15:51
entorenee
entorenee approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@entorenee entorenee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Looks great.

@illepic illepic merged commit 8675ecf into master Aug 30, 2018
@illepic illepic deleted the feature/inject-import-sass-variables branch September 5, 2018 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuginaili yuginaili yuginaili approved these changes

@entorenee entorenee entorenee approved these changes

Assignees

@illepic illepic

Labels
sass webpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illepic @yuginaili @entorenee