Improving the code and fixing some bugs#1
Merged
philipithomas merged 3 commits intophilipithomas:masterfrom Jul 20, 2016
Merged
Improving the code and fixing some bugs#1philipithomas merged 3 commits intophilipithomas:masterfrom
philipithomas merged 3 commits intophilipithomas:masterfrom
Conversation
added 3 commits
July 19, 2016 19:18
Owner
|
Thanks! Can you explain how the race would have worked? I didn't see any errors with the |
| // Use waitgroup so we can keep track of tasks | ||
| columns := []string{*name, *address, *phone, *email} | ||
| headers := []string{"name", "address", "phone", "email"} | ||
| // url and id are added as the first two rows. |
Contributor
Author
There was a problem hiding this comment.
I would call it columns, because those are the column names ... but it's really up to you
Owner
|
I really like the way the Scrape function was rewritten. |
Contributor
Author
|
There was no data race, sorry. But you were leaking go routines, which didn't have any effect on your binary since it's short lived |
Contributor
Author
|
So would you mind if I made a video of me reviewing this code and posted it on YouTube? 🙏 |
Owner
|
Yes @campoy - go for it! I sent you an email about it too. |
Repository owner
locked and limited conversation to collaborators
Jul 22, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You had data races 😄
The order of columns and headers did not match
Too many files for what it is, I think now is more readable
I'll use this code in a video where I show how I improved it, if you don't mind!