Upgraded Hazelcast Go Client to v1.3.0#112
Merged
philippgille merged 1 commit intophilippgille:masterfrom Aug 15, 2022
Merged
Conversation
Owner
|
Hi Yüce, thank you for the PR! It's an honor to get a contribution and additional info directly from a maintainer of one of the storages that
I noticed the GitHub Actions workflow didn't run, I think I have it only configured for pushes which also trigger for my own PRs, but not for PRs from contributors. I just recently switched from Travis CI to GitHub Actions. I'm going to change that, but for now I just checked out your branch and ran Thanks again! |
philippgille
added a commit
that referenced
this pull request
Aug 28, 2022
As per PR description #112
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Philipp, thanks for this cool project and including Hazelcast as an option to your users.
We've released Hazelcast Go Client v1.3.0 last month with important bug fixes (and new cool features!). Here's what was changed since v1.2.0:
This PR upgrades Hazelcast Go Client v1.2.0 to v1.3.0,
Starting with v1.3.0, we added support for the Near Cache, which keeps the map entries in memory and helps tremendously with read heavy workloads: https://pkg.go.dev/github.com/hazelcast/hazelcast-go-client#Map I am sure that's a feature your users can benefit from.
In your Hazelcast related code, you have this remark:
The answer is: Hazelcast Go Client handles this internally, no need to get the map again.
I also noticed that logging is turned off for the Hazelcast client with
config.Logger.Level = logger.OffLevelIn case you'd like to customize the output or use a different logger, It is possible to override it: https://pkg.go.dev/github.com/hazelcast/hazelcast-go-client@v1.3.0/logger#hdr-Using_a_Custom_LoggerThe gokv API is very clean and easy to use, but I would strongly suggest adding context support to it. Hazelcast Go Client supports it for all of its API, and it turned out to be a useful feature for our own users.
In case you'd like to join, we have our own Slack channel at: https://hazelcastcommunity.slack.com/channels/go-client You can get an invite at: https://slack.hazelcast.com/
Thanks again for your work!