Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
=======================================
Coverage 65.26% 65.26%
=======================================
Files 25 25
Lines 2096 2096
=======================================
Hits 1368 1368
Misses 601 601
Partials 127 127 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 2 is not maintained anymore, and there are not many changes to v3, so we can update without breaking anything on our side: allegro/bigcache@v2.2.5...v3.1.0
In fact, this update fixes a concurrency issue that was probably coming from BigCache side. Running
go test -v -race -count 100 -run TestStoreConcurrent .previously lead to one of the runs to have issues, but that seems to be solved.We actually run into this in CI fairly often (e.g. latest one here), so it's really useful to have this fixed.