Migrate MongoDB client from unmaintained 3rd party library to official one#165
Merged
philippgille merged 1 commit intomasterfrom Jan 7, 2024
Merged
Migrate MongoDB client from unmaintained 3rd party library to official one#165philippgille merged 1 commit intomasterfrom
philippgille merged 1 commit intomasterfrom
Conversation
…l one From github.com/globalsign/mgo to go.mongodb.org/mongo-driver
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 60.56% 63.64% +3.08%
==========================================
Files 25 25
Lines 2097 2107 +10
==========================================
+ Hits 1270 1341 +71
+ Misses 716 651 -65
- Partials 111 115 +4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When gokv was started, the 3rd-party library
github.com/globalsign/mgowas the most popular and mature MongoDB client library for Go. But that changed and the official librarygo.mongodb.org/mongo-driveris now the proper go-to library.mgois not maintained anymore and seems to not be compatible with newer versions of the MongoDB server anymore.This PR updates the MongoDB library from
github.com/globalsign/mgotogo.mongodb.org/mongo-driver.I haven't tested the new gokv implementation with an older MongoDB server version (where
mgostill worked), but from the way of how the document is defined, inserted/updated, read and deleted it could be compatible.I'll add a breaking change notice to the CHANGELOG as a warning in any case. (separately)