Remove test skipping on connection error#173
Merged
philippgille merged 3 commits intomasterfrom Jan 21, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
=======================================
Coverage 63.64% 63.64%
=======================================
Files 25 25
Lines 2107 2107
=======================================
Hits 1341 1341
Misses 651 651
Partials 115 115 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past, probably before we had the
mage test allthat automatically spins up Docker containers for the different store implementation tests, it was useful to do connection tests and skip tests when no connection could be established, to not fail an entire test run, but instead allow to check in the output log for any unexpected skips.The Docker container start has been very reliable though, while OTOH I've been less often checking for skipped tests, and it's also cumbersome to check with the long test output (and not using
tparseyet).=> This PR removes the connection check and test skipping from almost all store implementation tests.
The exceptions:
We leave the
checkConnectionfunctions in the test files even if they're not called, because they're very handy as soon as connection issues pop up, to find out if it's from thegokvclient specific code or the connection in general.