-
Notifications
You must be signed in to change notification settings - Fork 39
Add rootParentIds
option to fit the case when all items contain a valid parentId string
#24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rootParentIds
option to fit the case when all items contain a valid parentId string
#24
Conversation
…alid parentId string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, left a few comments.
I feel that we should not merge the supplied array with the default, but replace it. Otherwise there is no fine grained control when to throw. What do you think?
…alid parentId string
These modifications are completed, and I also added test case about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just one more note, please see the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rrbe sorry for the very late feedback, I just remembered there were some issues/PR still open here.
I have thought about the architecture a bit again and changed the data type for rootParentIds
to an object for better performance.
This should be fine now – I will merge it shortly.
Many thanks for your contribution and sorry again for the delay!
See #23