Work around macOS issue in which elements lose their window property

[nriley]

Also use double quotes consistently.

[phillco]

Is there a Talon issue for this we can link?

[phillco]

I think splitting it out into its own function can improve the readability a bit -- what do you think about this?

def extract_app(element) -> Optional[ui.App]:
    # Works around a macOS issue where elements lose their window property
    # https://github.com/talonvoice/talon/issues/XX
    while element:
        try:
            return element.window.app
        except (ui.UIErr, AttributeError):
            pass

        match element.AXRole:
            case "AXWindow":
                with suppress(AttributeError):
                    return element.app
            case "AXApplication":
                apps = ui.apps(name=element.AXTitle)
                if len(apps) == 1:
                    return apps[0]

        if not hasattr(element, "AXParent"):
            break

        element = element.parent
    return None

I normally would check for the property rather than catch the AttributeError, but since we're already doing this for ui.UIErr, I think it's cleaner and saves a level of indentation.

[nriley]

Nope, hadn't filed an issue but have now (talonvoice/talon#689).

Your refactor looks good to me. Unfortunately sometimes checking for properties doesn't always work right with UI elements (see the ticket above), so I've defaulted to catching/suppressing exceptions.