Skip to content

Make filter_out faster #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philss merged 1 commit into from
Dec 18, 2025
+11 −4
Merged

Make filter_out faster #650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions lib/floki/filter_out.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,22 @@ defmodule Floki.FilterOut do
defp filter(_, _), do: true

defp mapper(nodes, selector) when is_list(nodes) do
nodes
|> Stream.filter(&filter(&1, selector))
|> Stream.map(&mapper(&1, selector))
|> Enum.to_list()
do_mapper(nodes, selector, [])
end

defp mapper({nodetext, x, y}, selector) do
{nodetext, x, mapper(y, selector)}
end

defp mapper(nodetext, _), do: nodetext

defp do_mapper([], _selector, acc), do: Enum.reverse(acc)

defp do_mapper([head | tail], selector, acc) do
if filter(head, selector) do
do_mapper(tail, selector, [mapper(head, selector) | acc])
else
do_mapper(tail, selector, acc)
end
end
end
Loading