Skip to content

qa: allow use of symfony/console 6.x #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Conversation

ramsey
Copy link
Contributor

@ramsey ramsey commented Jan 2, 2022

Currently, if you attempt to install symfony/console 6.x into a project that also requires phly/keep-a-changelog, you will receive a Composer dependency resolution error. This is because phly/keep-a-changelog uses ^5.2.1 as the version constraint for symfony/console.

This PR allows projects using this package the ability to upgrade to the new 6.x series of symfony/console (or it allows packages already using symfony/console 6.x the ability to install phly/keep-a-changelog).

@@ -44,6 +44,10 @@
"sort-packages": true,
"platform": {
"php": "7.4.7"
},
"allow-plugins": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the allow-plugins property, since it will be a required property in the near future. See https://getcomposer.org/doc/06-config.md#allow-plugins

@lloricode
Copy link

+1

@weierophinney weierophinney changed the base branch from 2.11.x to 2.12.x September 2, 2022 13:36
@weierophinney weierophinney added this to the 2.12.0 milestone Sep 2, 2022
@weierophinney weierophinney merged commit b75b5cf into phly:2.12.x Sep 2, 2022
weierophinney added a commit that referenced this pull request Sep 2, 2022
Includes "Added" section with reference to #104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants